-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instr-express): use exported strings for attributes #2031
chore(instr-express): use exported strings for attributes #2031
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 90.97% 90.98%
=======================================
Files 146 145 -1
Lines 7492 7454 -38
Branches 1502 1488 -14
=======================================
- Hits 6816 6782 -34
+ Misses 676 672 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this 🙂
Were the tests left out intentionally? 🤔
🤦♀️ Oops! No they were not! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 🙂
Which problem is this PR solving?
Short description of the changes
In express instrumentation package:
@opentelemetry/semantic-conventions
to^1.22
SemanticAttributes.HTTP_ROUTE
with exported stringSEMATTRS_HTTP_ROUTE
README
with new semantic convention package version and key