Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resource-detector-container): use exported strings for attributes #2049

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-resource-detector-container:

  • Update @opentelemetry/semantic-conventions from ^1.0.0 to ^1.22.0
  • Use exported strings for Semantic Resource Attributes.

@JamieDanielson
Copy link
Member

Just a note, I recently updated the CONTRIBUTING doc because we no longer need to update the changelog on our own in PRs - it gets updated in the releasing step!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Merging #2049 (7e28bf3) into main (dfb2dff) will decrease coverage by 0.34%.
Report is 21 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
- Coverage   90.97%   90.63%   -0.34%     
==========================================
  Files         146      146              
  Lines        7492     7488       -4     
  Branches     1502     1494       -8     
==========================================
- Hits         6816     6787      -29     
- Misses        676      701      +25     
Files Coverage Δ
...ector-container/src/detectors/ContainerDetector.ts 92.85% <100.00%> (ø)

... and 8 files with indirect coverage changes

@JamieDanielson
Copy link
Member

Hmm I think that browser test is flaky, it looks similar to the failure I experienced on my PR too.

Use exported strings for Semantic Resource Attributes.

Signed-off-by: maryliag <[email protected]>
@maryliag
Copy link
Contributor Author

Updated to remove the changes on changelog.
I'll keep an eye on your PR if I would need to do something similar (or maybe it will pass on the next test run? 🤞 )

@pichlermarc pichlermarc merged commit 713abc5 into open-telemetry:main Mar 29, 2024
17 checks passed
@maryliag maryliag deleted the update-container branch March 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants