chore(test-utils): update semantic resource attributes #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
blumamir,
dyladan,
legendecas and
pichlermarc
github-actions
bot
added
pkg:instrumentation-ioredis
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg:resource-detector-alibaba-cloud
pkg:resource-detector-aws
pkg:resource-detector-gcp
pkg:resource-detector-instana
pkg:propagation-utils
pkg:instrumentation-amqplib
pkg:instrumentation-lru-memoizer
pkg:instrumentation-mongoose
pkg:instrumentation-tedious
pkg:instrumentation-aws-sdk
pkg:instrumentation-fastify
pkg:instrumentation-koa
pkg:instrumentation-memcached
pkg:instrumentation-mongodb
pkg:instrumentation-pg
pkg:instrumentation-pino
pkg:instrumentation-redis-4
pkg:instrumentation-redis
labels
59 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
- Coverage 90.97% 90.82% -0.16%
==========================================
Files 146 148 +2
Lines 7492 7672 +180
Branches 1502 1537 +35
==========================================
+ Hits 6816 6968 +152
- Misses 676 704 +28 |
trentm
approved these changes
Apr 9, 2024
trentm
reviewed
Apr 9, 2024
| | service.version | The version string of the service API or implementation. | | ||
| | telemetry.sdk.language | The language of the telemetry SDK. | | ||
| | telemetry.sdk.name | The name of the telemetry SDK. | | ||
| | telemetry.sdk.version | The version string of the telemetry SDK. | |
There was a problem hiding this comment.
I'd be inclined to drop the table for this package, an internal test utils package. But totally fine to have it in.
There was a problem hiding this comment.
Agree. I removed the table, but keep the message of semantic version, to keep consistent with other places.
Update Semantic Resource Attributes Part Of open-telemetry#2025 Signed-off-by: maryliag <[email protected]>
trentm
added
pkg:instrumentation-cassandra-driver
and removed
pkg:instrumentation-cassandra
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes