Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-mongodb): use exported strings for attributes #2088

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.* with exported strings SEMATTRS_*
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #2088 (5a71fb4) into main (dfb2dff) will decrease coverage by 0.16%.
Report is 46 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2088      +/-   ##
==========================================
- Coverage   90.97%   90.82%   -0.16%     
==========================================
  Files         146      148       +2     
  Lines        7492     7672     +180     
  Branches     1502     1537      +35     
==========================================
+ Hits         6816     6968     +152     
- Misses        676      704      +28     
Files Coverage Δ
...try-instrumentation-mongodb/src/instrumentation.ts 47.42% <100.00%> (-5.85%) ⬇️

... and 12 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 66d9cea into open-telemetry:main Apr 10, 2024
12 checks passed
@david-luna david-luna deleted the dluna/mongodb-semconv-strings branch June 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants