Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-mongoose): use exported strings for attributes #2103

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22
  • Replace SemanticAttributes.* with exported strings SEMATTRS_*
  • Update README with new semantic convention package version and key

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #2103 (eec3adc) into main (dfb2dff) will decrease coverage by 0.21%.
Report is 50 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
- Coverage   90.97%   90.77%   -0.21%     
==========================================
  Files         146      148       +2     
  Lines        7492     7675     +183     
  Branches     1502     1539      +37     
==========================================
+ Hits         6816     6967     +151     
- Misses        676      708      +32     

see 8 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 5f42c51 into open-telemetry:main Apr 17, 2024
12 checks passed
maryliag pushed a commit to maryliag/opentelemetry-js-contrib that referenced this pull request Apr 17, 2024
@david-luna david-luna deleted the dluna/mongoose-semconv-strings branch June 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants