Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/express): use exported strings for attributes #2121

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package examples/express:

  • Update @opentelemetry/semantic-conventions ^1.23.0
  • Use exported strings for Semantic Attributes.

@maryliag maryliag requested a review from a team April 19, 2024 17:56
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (dfb2dff) to head (152ca80).
Report is 82 commits behind head on main.

❗ Current head 152ca80 differs from pull request most recent head 299cff4. Consider uploading reports for the commit 299cff4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   90.97%   90.35%   -0.63%     
==========================================
  Files         146      147       +1     
  Lines        7492     7679     +187     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6938     +122     
- Misses        676      741      +65     

see 10 files with indirect coverage changes

@trentm trentm enabled auto-merge (squash) April 24, 2024 02:55
@trentm trentm disabled auto-merge April 24, 2024 06:32
@jarias-lfx
Copy link

/easycla

Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <[email protected]>
@trentm trentm enabled auto-merge (squash) April 25, 2024 22:40
@trentm trentm merged commit 7822461 into open-telemetry:main Apr 25, 2024
9 checks passed
@maryliag maryliag deleted the example-express branch April 26, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants