chore(examples/memcached): use exported strings for attributes #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use exported strings for Semantic Attributes Signed-off-by: maryliag <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2124 +/- ##
==========================================
- Coverage 90.97% 90.35% -0.63%
==========================================
Files 146 147 +1
Lines 7492 7679 +187
Branches 1502 1575 +73
==========================================
+ Hits 6816 6938 +122
- Misses 676 741 +65 |
59 tasks
JamieDanielson
approved these changes
Apr 23, 2024
| @@ -31,8 +31,10 @@ | |||
| "@opentelemetry/api": "^1.0.2", | |||
| "@opentelemetry/instrumentation": "^0.25.0", | |||
| "@opentelemetry/instrumentation-memcached": "^0.23.0", | |||
| "@opentelemetry/sdk-trace-node": "^0.25.0", | |||
| "@opentelemetry/resources": "^1.23.0", | |||
There was a problem hiding this comment.
good catch on this missing package 🙂
trentm
approved these changes
Apr 24, 2024
|
/easycla |
blumamir
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
On package
examples/memcached:@opentelemetry/semantic-conventions^1.23.0