docs: remove unused semconv packages and document #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
approved these changes
May 13, 2024
|
This could potentially add instr-bunyan. See #2195 (review) |
trentm
approved these changes
May 13, 2024
|
The instr-bunyan update went in (#2195) without a README reference. @JamieDanielson If you like you could add the "This package does not currently generate" README blurb to instr-bunyan as well here. Else I can in a separate PR. |
59 tasks
OK yeah I'll add that here real quick 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
- Coverage 90.97% 90.00% -0.98%
==========================================
Files 146 140 -6
Lines 7492 6903 -589
Branches 1502 1453 -49
==========================================
- Hits 6816 6213 -603
- Misses 676 690 +14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
@opentelemetry/semantic-conventionspackage that is unused:@opentelemetry/instrumentation-lru-memoizer@opentelemetry/instrumentation-dns@opentelemetry/instrumentation-generic-pool@opentelemetry/instrumentation-pino@opentelemetry/instrumentation-winston@opentelemetry/plugin-react-load@opentelemetry/sampler-aws-xrayNote these are intentionally done in separate commits to make it easier to see each change, and also so I can easily move these into separate PRs if that seems easier to deal with. I combined for now because of the minimal impact overall but very open to feedback.
Also, part of this will need to be addressed in some follow-ups after discussion from #2170 ... namely that some of these are still emitting attributes, just not semantic-convention attributes. This does not address that in any way, only documenting the current state.