Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(instrumentation-memcached): use exported strings for attributes #2192

Merged
merged 3 commits into from
May 14, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

On package opentelemetry-instrumentation-memcached:

  • Update @opentelemetry/semantic-conventions ^1.23.0
  • Use exported strings for Semantic Attributes.

Update to use strings exported for Resource Attributes

Signed-off-by: maryliag <[email protected]>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (e1c7a09).
Report is 109 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.51%     
==========================================
  Files         146      149       +3     
  Lines        7492     7592     +100     
  Branches     1502     1591      +89     
==========================================
+ Hits         6816     6869      +53     
- Misses        676      723      +47     
Files Coverage Δ
...y-instrumentation-memcached/src/instrumentation.ts 96.22% <ø> (-0.21%) ⬇️
...entelemetry-instrumentation-memcached/src/utils.ts 80.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

@trentm trentm enabled auto-merge (squash) May 14, 2024 18:36
@trentm trentm merged commit 025abda into open-telemetry:main May 14, 2024
4 checks passed
@maryliag maryliag deleted the sem-memcached branch May 14, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants