-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-nestjs-core): use strings exported for attributes #2193
Conversation
Update strings exported for Resource Attributes Signed-off-by: maryliag <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2193 +/- ##
==========================================
- Coverage 90.97% 90.47% -0.51%
==========================================
Files 146 149 +3
Lines 7492 7592 +100
Branches 1502 1591 +89
==========================================
+ Hits 6816 6869 +53
- Misses 676 723 +47
|
These attributes are not in semconv:
and are relevant for the outcome of #2170 |
@@ -71,7 +71,7 @@ | |||
}, | |||
"dependencies": { | |||
"@opentelemetry/instrumentation": "^0.51.0", | |||
"@opentelemetry/semantic-conventions": "^1.0.0" | |||
"@opentelemetry/semantic-conventions": "^1.23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
"@opentelemetry/semantic-conventions": "^1.23.0" | |
"@opentelemetry/semantic-conventions": "^1.22.0" |
Which problem is this PR solving?
Short description of the changes
On package
opentelemetry-instrumentation-nestjs-core
:@opentelemetry/semantic-conventions
^1.23.0