Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B3 Propagator should left-pad 64-bit trace IDs with zeros #1020

Closed
Aneurysm9 opened this issue May 5, 2020 · 1 comment · Fixed by #1021
Closed

B3 Propagator should left-pad 64-bit trace IDs with zeros #1020

Aneurysm9 opened this issue May 5, 2020 · 1 comment · Fixed by #1021
Assignees
Labels
bug Something isn't working

Comments

@Aneurysm9
Copy link
Member

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

HEAD

What version of Node are you using?

N/A

What did you do?

Provide a 64-bit trace ID in a B3 header.

What did you expect to see?

The 64-bit trace ID left-padded with zeros in the SpanContext.

What did you see instead?

The SpanContext is not propagated as the validation regexp only allows for 32 hex digit trace IDs.

Additional context

See open-telemetry/opentelemetry-go#686

@Aneurysm9 Aneurysm9 added the bug Something isn't working label May 5, 2020
@dyladan dyladan self-assigned this May 5, 2020
@dyladan
Copy link
Member

dyladan commented May 5, 2020

@Aneurysm9 #1021

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
* chore: harmonize dependencies

Harmonize dependencies by using following rules:
* peer and dev depend on API ^1.0.0 (like in core repo)
* depend on SDK ^1.0.0 (don't limit user)
* dev-depend on latest SDK pinned (like other deps)
* pin dependencies within the lerna project (like in core repo)

* chore: re-add shimmer
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
* chore: harmonize dependencies

Harmonize dependencies by using following rules:
* peer and dev depend on API ^1.0.0 (like in core repo)
* depend on SDK ^1.0.0 (don't limit user)
* dev-depend on latest SDK pinned (like other deps)
* pin dependencies within the lerna project (like in core repo)

* chore: re-add shimmer
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 16, 2024
* chore: harmonize dependencies

Harmonize dependencies by using following rules:
* peer and dev depend on API ^1.0.0 (like in core repo)
* depend on SDK ^1.0.0 (don't limit user)
* dev-depend on latest SDK pinned (like other deps)
* pin dependencies within the lerna project (like in core repo)

* chore: re-add shimmer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants