Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource timing spans with events to DocumentLoad plugin #456

Closed
draffensperger opened this issue Oct 23, 2019 · 1 comment · Fixed by #478
Closed

Add resource timing spans with events to DocumentLoad plugin #456

draffensperger opened this issue Oct 23, 2019 · 1 comment · Fixed by #478
Assignees
Milestone

Comments

@draffensperger
Copy link
Contributor

draffensperger commented Oct 23, 2019

I would suggest that we use the Resource Timing API to get spans for all of the resource timing events that occur before the end of the load event in the browser as part of the DocumentLoad plugin. Each span should include any network events (DNS resolution, SSL handshake, request start, etc.) as TimedEvents on the span when present.

We did this in OpenCensus Web, see this trace screenshot and this code link

@obecny what would you think about adding this feature?

@obecny
Copy link
Member

obecny commented Nov 1, 2019

please assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants