Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-trace] make activeSpanProcessor private #4792

Open
4 tasks
pichlermarc opened this issue Jun 14, 2024 · 1 comment · May be fixed by #4965
Open
4 tasks

[sdk-trace] make activeSpanProcessor private #4792

pichlermarc opened this issue Jun 14, 2024 · 1 comment · May be fixed by #4965

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Jun 14, 2024

Description

activeSpanProcessor is currently public and that allows users to modify the span processor by setting it on the fly even though the should be done via addSpanProcesssor() or - ideally - only via the constructor as the user is not supposed to hold on to the SDK instance of the TracerProvider after the initialization phase, as this can have unintended side-effects on the exported telemetry and should therefore be avoided.

This issue is considered done when

  • the activeSpanProcessor property at has been marked private or protected
  • it has been verified that activeSpanProcessor is not public in any other way for the BasicTracerProvider
  • it has been verified that activeSpanProcessor is not public in any other way for the WebTracerProvider
  • it has been verified that activeSpanProcessor is not public in any other way for the NodeTracerProvider
@legalimpurity
Copy link
Contributor

@pichlermarc can I pick this up?

@legalimpurity legalimpurity linked a pull request Aug 29, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants