fix(sdk-trace): make activeSpanProcessor private #4965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry#4935) Co-authored-by: Daniel Patrick <[email protected]>
…sivity (open-telemetry#4829) Co-authored-by: Hector Hernandez <[email protected]>
…lemetry#4589) Co-authored-by: Marc Pichler <[email protected]> Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Jackson Weber <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
) Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Mend Renovate <[email protected]>
|
Hi, thanks for working on this, would you mind chaging the target to the All breaking changes from the SDK 2.0 Milestone usually go onto the next branch 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This addresses the issue of making activeSpanProcessor private.
Fixes #4792
Short description of the changes
Makes activeSpanProcessor private in BasicTracerProvider.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A few tests that were accessing the property have been fixed.
Checklist: