Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove unused protobufjs and update used ones to 7.1.1 #3251

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

protobufjs was oudated and unused in some packages. This PR:

  • Moves the dependency on protobufjs from @opentelemetry/exporter-trace-otlp-proto and @opentelemetry/exporter-metrics-otlp-proto to @opentelemetry/otlp-proto-exporter-base.
  • Removes the dependency on protobufjs from @opentelemetry/otlp-transformer as it is not used there.
  • Adds a dev dependency on protobufjs-cli to @opentelemetry/otlp-proto-exporter-base, as the CLI has been moved to its own package in https://github.com/protobufjs/protobuf.js/releases/tag/protobufjs-v7.0.0
  • Updates all dependencies to protobufjs to 7.1.1

Supersedes #3164

How Has This Been Tested?

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3251 (b1bca19) into main (ec56837) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b1bca19 differs from pull request most recent head bc8d1d5. Consider uploading reports for the commit bc8d1d5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   92.91%   92.93%   +0.01%     
==========================================
  Files         188      188              
  Lines        5870     5870              
  Branches     1242     1242              
==========================================
+ Hits         5454     5455       +1     
+ Misses        416      415       -1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@pichlermarc pichlermarc marked this pull request as ready for review September 14, 2022 06:34
@pichlermarc pichlermarc requested a review from a team September 14, 2022 06:34
@legendecas legendecas merged commit 4422d8c into open-telemetry:main Sep 15, 2022
@pichlermarc pichlermarc deleted the deps/protobufjs branch September 15, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants