-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-node): update instrumentations once MeterProvider is initialized #3624
Merged
dyladan
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:bugfix/3609-broken-metrics-instrumentations
Mar 2, 2023
Merged
fix(sdk-node): update instrumentations once MeterProvider is initialized #3624
dyladan
merged 8 commits into
open-telemetry:main
from
dynatrace-oss-contrib:bugfix/3609-broken-metrics-instrumentations
Mar 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3624 +/- ##
==========================================
- Coverage 93.25% 92.54% -0.71%
==========================================
Files 265 172 -93
Lines 7484 3929 -3555
Branches 1556 796 -760
==========================================
- Hits 6979 3636 -3343
+ Misses 505 293 -212
|
Flarna
approved these changes
Feb 27, 2023
dyladan
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In
@opentelemetry/sdk-node
instrumentations are registered before the SDKMeterProvider
is registered, causing the instrumentations to be left with aNoopMeterProvider
, and subsequentlyNoopMeter
and then no-op instruments, which causes all metrics data provided to these instruments to be dropped.This is only the case for metrics, as the Trace API implements a delegating no-op instead. Once we implement a delegating no-op for the Metrics API (#3622), the workaround proposed by this PR will become obsolete.
Fixes #3609
Short description of the changes
Updates instrumentations once MeterProvider is registered to avoid no-ops being used.
Type of change
How Has This Been Tested?
Checklist: