Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export DiagLoggerOptions Type #3639

Merged

Conversation

altinokdarici
Copy link
Contributor

@altinokdarici altinokdarici commented Feb 28, 2023

Which problem is this PR solving?

Short description of the changes

Exporting DiagLoggerOptions interface in index.ts

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 28, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@altinokdarici
Copy link
Contributor Author

/easycla

@altinokdarici altinokdarici marked this pull request as ready for review February 28, 2023 08:08
@altinokdarici altinokdarici requested a review from a team February 28, 2023 08:08
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #3639 (4b8e336) into main (a457d94) will increase coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 4b8e336 differs from pull request most recent head 5c79f2b. Consider uploading reports for the commit 5c79f2b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
+ Coverage   93.10%   93.73%   +0.63%     
==========================================
  Files         183      274      +91     
  Lines        4538     8058    +3520     
  Branches      905     1670     +765     
==========================================
+ Hits         4225     7553    +3328     
- Misses        313      505     +192     
Impacted Files Coverage Δ
api/src/diag/types.ts 100.00% <ø> (ø)
...-trace-base/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (ø)
packages/sdk-metrics/src/state/MetricCollector.ts 100.00% <0.00%> (ø)
...telemetry-sdk-trace-node/src/NodeTracerProvider.ts 95.00% <0.00%> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <0.00%> (ø)
...ages/sdk-metrics/src/exemplar/ExemplarReservoir.ts 95.65% <0.00%> (ø)
packages/sdk-metrics/src/view/MeterSelector.ts 100.00% <0.00%> (ø)
packages/sdk-metrics/src/view/Predicate.ts 100.00% <0.00%> (ø)
...elemetry-propagator-jaeger/src/JaegerPropagator.ts 100.00% <0.00%> (ø)
...kages/opentelemetry-propagator-b3/src/constants.ts 100.00% <0.00%> (ø)
... and 86 more

@Flarna
Copy link
Member

Flarna commented Feb 28, 2023

There seems to be a type name conflict with logger API. see #3640
But I think it's implicit exported in API already so rename would be breaking.

@altinokdarici
Copy link
Contributor Author

There seems to be a type name conflict with logger API. see #3640 But I think it's implicit exported in API already so rename would be breaking.

Commented in the issue #3640

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking for now until #3640 comes to a conclusion.

@altinokdarici altinokdarici changed the title Export LoggerOptions Type Export DiagLoggerOptions Type Mar 2, 2023
@altinokdarici
Copy link
Contributor Author

blocking for now until #3640 comes to a conclusion.

Blocker has been resolved. We can continue with this PR.

@pichlermarc pichlermarc merged commit 6f3e96f into open-telemetry:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiagLoggerOptions interface is not exported
4 participants