-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export DiagLoggerOptions Type #3639
Export DiagLoggerOptions Type #3639
Conversation
/easycla |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3639 +/- ##
==========================================
+ Coverage 93.10% 93.73% +0.63%
==========================================
Files 183 274 +91
Lines 4538 8058 +3520
Branches 905 1670 +765
==========================================
+ Hits 4225 7553 +3328
- Misses 313 505 +192
|
There seems to be a type name conflict with logger API. see #3640 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking for now until #3640 comes to a conclusion.
9f113e5
to
5c79f2b
Compare
Blocker has been resolved. We can continue with this PR. |
Which problem is this PR solving?
DiagLoggerApi.setLogger
has two overrides. One of them hasoptions: DiagLoggerOptions
parameter. However,DiagLoggerOptions
is not exported throughindex.ts
.Fixes DiagLoggerOptions interface is not exported #3638
Short description of the changes
Exporting
DiagLoggerOptions
interface in index.tsType of change
How Has This Been Tested?
N/A
Checklist: