-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-metrics): allow single bucket histograms #4456
Merged
pichlermarc
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/allow-emtpy-bucket-advice
Feb 6, 2024
Merged
fix(sdk-metrics): allow single bucket histograms #4456
pichlermarc
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:fix/allow-emtpy-bucket-advice
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
==========================================
- Coverage 93.12% 92.93% -0.20%
==========================================
Files 82 259 +177
Lines 1658 6991 +5333
Branches 341 1459 +1118
==========================================
+ Hits 1544 6497 +4953
- Misses 114 494 +380
|
pichlermarc
force-pushed
the
fix/allow-emtpy-bucket-advice
branch
from
February 1, 2024 12:08
44f7bf7
to
183a1d2
Compare
legendecas
reviewed
Feb 4, 2024
legendecas
approved these changes
Feb 6, 2024
pichlermarc
added
bug
Something isn't working
priority:p1
Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
labels
Feb 6, 2024
This was referenced Jun 15, 2024
This was referenced Jun 21, 2024
This was referenced Jun 22, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
* fix(sdk-metrics): allow single bucket histograms * test(sdk-metrics): undefined and null inputs for bucket boundaries * fixup! test(sdk-metrics): undefined and null inputs for bucket boundaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
priority:p1
Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When creating a histogram with an empty bucket via the API, the SDK throws. Such a histogram can be useful if just min/max/sum/count are needed. Since previously, the only way to set up an aggregation would have been via
View
s, it was fine forExplicitBucketHistogramAggregation
to throw (View
creation happens on SDK setup). Now that the same thing can happen via the API we need to ensure that we do not throw.Further, reading through the spec it looks like single-bucket histograms are actually permitted. Therefore, I didn't change it to log a warning instead.
I added a few more tests to ensure that this special case is covered works with the the existing aggregators.
Type of change
How Has This Been Tested?