-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(instr-http): document semantic conventions and attributes in use #4587
Merged
pichlermarc
merged 3 commits into
open-telemetry:main
from
JamieDanielson:jamie.http-semconv-readme
Mar 28, 2024
Merged
docs(instr-http): document semantic conventions and attributes in use #4587
pichlermarc
merged 3 commits into
open-telemetry:main
from
JamieDanielson:jamie.http-semconv-readme
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4587 +/- ##
==========================================
- Coverage 92.84% 92.83% -0.02%
==========================================
Files 328 328
Lines 9494 9494
Branches 2040 2040
==========================================
- Hits 8815 8814 -1
- Misses 679 680 +1 |
MSNev
approved these changes
Mar 27, 2024
59 tasks
This was referenced May 28, 2024
Open
4 tasks
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…open-telemetry#4587) * docs(instr-http): document semantic conventions in use * add changelog entry --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
I didn't see a specific issue for this, so realizing there should probably be another issue similar to open-telemetry/opentelemetry-js-contrib#1778 in this repo, for the instrumentations within.
This is intended to let folks know what version of semantic conventions are in use as well as the attributes exported in the instrumentation. This will make it easier to update to later versions when ready (see tracking issue #4572).
Short description of the changes
1.22+
" because even though the numbered version will change with each release, right now it's effective in 1.22+ that contains the exported string keys. When we have a new semantic convention package with new attributes, we can adjust that.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: