-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk-logs): make dropping attribute print message #4614
feat(sdk-logs): make dropping attribute print message #4614
Conversation
@HyunnoH thanks for working on this. Please add a changelog so we can proceed 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4614 +/- ##
==========================================
+ Coverage 92.83% 93.41% +0.58%
==========================================
Files 329 198 -131
Lines 9528 6667 -2861
Branches 2053 1421 -632
==========================================
- Hits 8845 6228 -2617
+ Misses 683 439 -244
|
…#4614) * feat(sdk-logs): make dropping attribute print message * chore: update changelog * chore(sdk-logs): add comment to explain message logic * Update experimental/CHANGELOG.md --------- Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
Make dropping attribute print message.
Fixes #3762
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: