chore(deps): package-lock maintainance

[pichlermarc]

Updates dependencies in package-lock.json, first commit is actually #4620. This will be rebased once it's merged.

[trentm]

Whoa, a 41k line change to package-lock?

[pichlermarc]

Ah, something must've gone wrong - I actually just ran npm update.
I'll look into it once we're done with #4620

[trentm]

I see that in #4601 part of the change to package-lock included this:

diff --git a/package-lock.json b/package-lock.json
index 6cc71665..503a0f15 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -10,7 +10,6 @@
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "workspaces": [
-        "api",
         "packages/*",
         "experimental/packages/*",
         "experimental/examples/*",
        

I don't know that that is problematic, but it is weird.

[trentm]

package-lock and npm workspaces sure are a ride.

[pichlermarc]

I don't know that that is problematic, but it is weird.

I think I know why this happens: It must be the prepare release script, we remove the API there so that lerna can do it's thing. We'll likely need to sync package-lock again after we do that.

[pichlermarc]

I don't know that that is problematic, but it is weird.

I think I know why this happens: It must be the prepare release script, we remove the API there so that lerna can do it's thing. We'll likely need to sync package-lock again after we do that.

#4623 should take care of this.

[trentm]

I actually just ran npm update.

I tried that too, and my diff is 72k! :)

% git diff | wc -l
   72979

I don't really know what to say. I think the huge diff is from shuffling around where deps are installed. E.g. in my 72k line diff, all the mocha@10 deps were shuffled from the top-level node_modules/ to the separate .../node_modules/ dirs for each package... and the one usage of mocha@9 moved to the top-level.

I guess we just take it and move on.

[pichlermarc]

I actually just ran npm update.

I tried that too, and my diff is 72k! :)

New highscore :D

% git diff | wc -l
   72979

I don't really know what to say. I think the huge diff is from shuffling around where deps are installed. E.g. in my 72k line diff, all the mocha@10 deps were shuffled from the top-level node_modules/ to the separate .../node_modules/ dirs for each package... and the one usage of mocha@9 moved to the top-level.

I guess we just take it and move on.

I'll try to enable packge-lock maintainance on renovate bot. Maybe it can manage to produce a diff that's a bit less daunting to look at. 🤔

[pichlermarc]

PR to enable lock file maintenance, let's see what it does: #4628 🙂

[pichlermarc]

Closing this for now as I think going the renovate route will be better.