Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixing: TelemetryAPI receiver #1346

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Bug fixing: TelemetryAPI receiver #1346

merged 1 commit into from
Jun 13, 2024

Conversation

jerrytfleung
Copy link
Contributor

@jerrytfleung jerrytfleung commented May 24, 2024 •
edited
Loading

  • Decoupled API version and Schema version
  • Updated schema version to "2022-12-13"
  • Fixed Record datatype. It should be any. Record could be a string in function type.

@jerrytfleung jerrytfleung requested a review from a team May 24, 2024 23:03
tylerbenson
tylerbenson approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @rapphil @nslaughter PTAL.

@tylerbenson tylerbenson added the go Pull requests that update Go code label Jun 13, 2024
@tylerbenson tylerbenson merged commit 6867c50 into open-telemetry:main Jun 13, 2024
12 checks passed
@rapphil
Copy link
Contributor

rapphil commented Jun 17, 2024

Late to the party, but LGTM as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerrytfleung @rapphil @tylerbenson