Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ruby prod release #1362

Merged
merged 2 commits into from
Jun 3, 2024
Merged

feat: ruby prod release #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d483a16
feat: ruby prod release
xuan-cao-swi Jun 3, 2024
edef883
Update ruby/README.md
xuan-cao-swi Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-layer-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@ jobs:
layer-name: opentelemetry-ruby
component-version: ${{needs.build-layer.outputs.RUBY_SDK_VERSION}}
runtimes: ruby3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's preventing you from adding ruby3.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think current implementation that use template.yaml to build layer restrict multiple runtimes; especially with default GEM_PATH (e.g. ruby/gems/3.2.0). If use template.yaml and sam to build the layer, it will fetch the image
public.ecr.aws/sam/build-<language>-<language_version> (e.g. public.ecr.aws/sam/build-python3.9; public.ecr.aws/sam/build-ruby3.2).

I will create an issue to track the issue and find way to support multiple runtimes under one layer (if possible).

release-group: dev
release-group: prod
aws_region: ${{ matrix.aws_region }}
secrets: inherit
23 changes: 12 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Some layers include the corresponding OTel language SDK for the Lambda. This all
* ### [Java + Collector Lambda Layer](java/README.md)
* ### [NodeJS + Collector Lambda Layer](nodejs/README.md)
* ### [.NET + Collector Lambda Layer](dotnet/README.md)
* ### [Ruby + Collector Lambda Layer](ruby/README.md)
* ### [Collector Lambda Layer](collector/README.md)

## FAQ
Expand Down Expand Up @@ -69,17 +70,17 @@ The table below captures the state of various features and their levels of suppo

| Feature | Node | Python | Java | .NET | Go | Ruby |
| -------------------------- | :--: | :----: | :--: | :--: | :--: | :--: |
| OpenTelemetry collector | + | + | + | + | + | |
| Custom context propagation | + | - | - | - | N/A | |
| X-Ray Env Var Span Link | - | - | - | - | N/A | |
| Semantic Conventions^ | | + | + | + | N/A | |
| - Trace General^<sup>[1]</sup> | + | | + | + | N/A | |
| - Trace Incoming^<sup>[2]</sup> | - | | - | + | N/A | |
| - Trace Outgoing^<sup>[3]</sup> | + | | - | + | N/A | |
| - Metrics^<sup>[4]</sup> | - | | - | - | N/A | |
| Auto instrumentation | | + | + | - | N/A | |
| Flush TracerProvider | + | + | | + | + | |
| Flush MeterProvider | + | + | | | | |
| OpenTelemetry collector | + | + | + | + | + | + |
| Custom context propagation | + | - | - | - | N/A | + |
| X-Ray Env Var Span Link | - | - | - | - | N/A | - |
| Semantic Conventions^ | | + | + | + | N/A | + |
| - Trace General^<sup>[1]</sup> | + | | + | + | N/A | + |
| - Trace Incoming^<sup>[2]</sup> | - | | - | + | N/A | - |
| - Trace Outgoing^<sup>[3]</sup> | + | | - | + | N/A | + |
| - Metrics^<sup>[4]</sup> | - | | - | - | N/A | - |
| Auto instrumentation | | + | + | - | N/A | + |
| Flush TracerProvider | + | + | | + | + | + |
| Flush MeterProvider | + | + | | | | - |

#### Legend

Expand Down
1 change: 1 addition & 0 deletions ruby/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Requirement:
* [Go](https://go.dev/doc/install)
* [Docker](https://docs.docker.com/get-docker)

Current ruby layer only supports ruby 3.2.0

## Building Lambda Ruby Layer With OpenTelemetry Ruby Dependencies

Expand Down
Loading