Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Port key value parser from Stanza #459

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

jsirianni
Copy link
Member

Resolves #455

@jsirianni jsirianni mentioned this pull request Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #459 (c182e23) into main (f9887c7) will increase coverage by 1.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #459     +/-   ##
=======================================
+ Coverage   75.4%   76.7%   +1.3%     
=======================================
  Files         83      84      +1     
  Lines       3888    4111    +223     
=======================================
+ Hits        2933    3155    +222     
+ Misses       673     671      -2     
- Partials     282     285      +3     
Impacted Files Coverage Δ
operator/parser/keyvalue/keyvalue.go 100.0% <100.0%> (ø)
entry/resource_field.go 97.6% <0.0%> (-2.4%) ⬇️
entry/attribute_field.go 97.6% <0.0%> (-2.4%) ⬇️
operator/input/tcp/tcp.go 78.4% <0.0%> (-1.6%) ⬇️
entry/body_field.go 100.0% <0.0%> (ø)
operator/transformer/recombine/recombine.go 77.7% <0.0%> (+2.0%) ⬆️
entry/field.go 98.1% <0.0%> (+2.9%) ⬆️
operator/helper/severity_builder.go 90.3% <0.0%> (+4.6%) ⬆️

@jsirianni jsirianni marked this pull request as ready for review March 28, 2022 19:32
@jsirianni jsirianni requested a review from a team March 28, 2022 19:32
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple nits.

operator/parser/keyvalue/keyvalue.go Outdated Show resolved Hide resolved
operator/parser/keyvalue/keyvalue.go Outdated Show resolved Hide resolved
operator/parser/keyvalue/keyvalue.go Outdated Show resolved Hide resolved
@jsirianni
Copy link
Member Author

@djaglowski thanks for the review, everything should be sorted out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Key-Value parser from stanza
2 participants