Remove nodejs autoinstrumentation dev dependencies from image

[Zirak]

Description:

The autoinstrumentation has several build-time dependencies which aren't necessary for the final image, like typescript. Comparison of builds without typescript, typescript + rimraf, and finally all dev dependencies:

$ docker image ls --format 'table {{.Repository}} {{.Tag}} {{.Size}}'
autoinstrumentation-nodejs 60d37e18ce 272MB
autoinstrumentation-nodejs no-ts 208MB
autoinstrumentation-nodejs no-ts-rmrf 201MB
autoinstrumentation-nodejs no-dev 200MB

We extend the existing postcompile script. After building into build/workspace, we prune to remove extraneous packages. Doing that requires the package.json in the build directory.

Link to tracking Issue(s):

• Resolves: Node autoinstrumentation image includes dev dependencies #2802

Testing: Locally instrumenting a nodejs application.

[swiatekm]

LGTM, but someone with a better understanding of the node instrumentation should double-check before we merge.

I do wonder if we won't break anyone with this change. Technically, nobody should be using these dependencies, but you never know.

[Zirak]

Thanks!

Technically, nobody should be using these dependencies, but you never know.

Interesting! From my understanding the only possible user for these dependencies is the nodejs agent itself. Since the modules end up in /autoinstrumentation/node_modules, an end user shouldn't really be exposed to them.