Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply logging spec updates #977

Merged
merged 1 commit into from
Apr 18, 2023
Merged

apply logging spec updates #977

merged 1 commit into from
Apr 18, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Apr 18, 2023

Removing include_trace_context parameter
Set ObservedTimestamp on emit if not already set
Rename logRecord to emit

Removing include_trace_context parameter
Set ObservedTimestamp on emit if not already set
Rename logRecord to emit
@brettmc brettmc requested a review from a team April 18, 2023 04:22
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #977 (e58d7e0) into main (a06e5e4) will decrease coverage by 0.45%.
The diff coverage is 76.23%.

❗ Current head e58d7e0 differs from pull request most recent head 12ed8fe. Consider uploading reports for the commit 12ed8fe to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #977      +/-   ##
============================================
- Coverage     82.95%   82.50%   -0.45%     
  Complexity     2165     2165              
============================================
  Files           281      283       +2     
  Lines          6195     6197       +2     
============================================
- Hits           5139     5113      -26     
- Misses         1056     1084      +28     
Flag Coverage Δ
7.4 81.17% <76.23%> (-0.45%) ⬇️
8.0 82.44% <76.23%> (-0.47%) ⬇️
8.1 82.56% <76.23%> (-0.47%) ⬇️
8.2 82.56% <76.23%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...I/Common/Instrumentation/CachedInstrumentation.php 83.33% <0.00%> (ø)
src/API/Logs/NoopLogger.php 100.00% <ø> (ø)
src/SDK/Metrics/Data/Exemplar.php 0.00% <0.00%> (ø)
...SDK/Metrics/Stream/AsynchronousMetricCollector.php 0.00% <0.00%> (ø)
.../SDK/Metrics/Stream/SynchronousMetricCollector.php 0.00% <0.00%> (ø)
src/SDK/Logs/ReadableLogRecord.php 91.89% <80.00%> (-2.71%) ⬇️
src/SDK/Metrics/Stream/MetricAggregator.php 96.29% <80.00%> (-3.71%) ⬇️
src/API/Logs/EventLogger.php 100.00% <100.00%> (ø)
src/API/Logs/NoopLoggerProvider.php 100.00% <100.00%> (ø)
src/SDK/Logs/Logger.php 100.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06e5e4...12ed8fe. Read the comment docs.

$this->context = $logRecord->context;
if ($includeTraceContext) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not part of the spec?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed in the last couple of days. The changes in this PR are referenced in open-telemetry/opentelemetry-specification#2911

@pdelewski pdelewski merged commit 8f70a6d into open-telemetry:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants