Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otlp-proto to v0.11.0 #30

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Update otlp-proto to v0.11.0 #30

merged 2 commits into from
Nov 11, 2021

Conversation

MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented Nov 10, 2021 •
edited by MikeGoldsmith
Loading

This is a rebase of @MikeGoldsmith work. This was done because I don't have write access to resolve the conflicts.

Closes #28

@MadVikingGod MadVikingGod requested a review from a team November 10, 2021 17:20
@MadVikingGod
Copy link
Contributor Author

Added an update to grpc version to fix the generation check. This will close #29

MikeGoldsmith
MikeGoldsmith approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MadVikingGod - I totally forgot I started this 👍🏻

@MikeGoldsmith MikeGoldsmith merged commit 21600d6 into open-telemetry:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@MrAlias MrAlias MrAlias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MadVikingGod @MikeGoldsmith @MrAlias