Improve lookup table pattern use in profiles. #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos68k
reviewed
Oct 21, 2024
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
christos68k
approved these changes
Oct 30, 2024
trask
approved these changes
Oct 30, 2024
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
felixge
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
LGTM. Nits (that could be addressed in follow-up PRs)
- Why
int32instead ofuint32for the indexes? I'd prefer the latter, but don't feel strongly. key_strindexandlink_indexfeels inconsistent. My preference would bekey_string_index(same for other string indexes)
|
This has the required number of approvals. The rules require that we keep it open for 2 days since the last substantial change before merging. I will merge after that. |
|
uint32 has the same problem as int64 - it can hold values that don't map cleanly to the signed 32 bit array range in Java. It would express intent more clearly, but potentially cause more headaches for implementers. |
aalexand
reviewed
Nov 1, 2024
aalexand
reviewed
Nov 1, 2024
aalexand
approved these changes
Nov 1, 2024
|
All comments must be resolved before we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on implementation experience with the draft version of the profiles spec, the use of lookup tables for storing values is space efficient but not particularly user friendly. This change makes improvements by changing field names to clarify their role in the pattern and changing their data types to better accommodate their use in languages limited to 32 bit array indexing e.g. Java.