Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize DB_STATEMENT by default for elasticsearch #1758

Merged

Conversation

nemoshlag
Copy link
Member

@nemoshlag nemoshlag commented Apr 16, 2023

Description

Default sanitize query for DB_STATEMENT attribute, according to open-telemetry/opentelemetry-specification#3127
Fixes #1755 for elasticsearch

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tox -e test-instrumentation-elasticsearch{2}
  • tox -e test-instrumentation-elasticsearch5
  • tox -e test-instrumentation-elasticsearch{6}

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@nemoshlag nemoshlag marked this pull request as ready for review April 17, 2023 09:28
@nemoshlag nemoshlag requested a review from a team April 17, 2023 09:28
@nemoshlag nemoshlag changed the title sanitize db statement by default Sanitize DB_STATEMENT by default for elasticsearch Apr 17, 2023
@srikanthccv srikanthccv merged commit 19fe771 into open-telemetry:main Apr 23, 2023
@nemoshlag nemoshlag deleted the fix/elastic-search/db-statement branch May 1, 2023 08:20
@phillipuniverse
Copy link
Contributor

This sanitization implementation does not work for the elasticsearch bulk api, see #1868.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only collect db.statement if there is sanitization
4 participants