Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlalchemy instrumentation to follow semantic conventions #202

Merged
merged 10 commits into from
Nov 23, 2020

Conversation

srikanthccv
Copy link
Member

Description

Part of #159

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@srikanthccv srikanthccv requested review from a team, owais and lzchen and removed request for a team November 21, 2020 19:55
@srikanthccv
Copy link
Member Author

FYI @NathanielRN .

@@ -78,7 +78,6 @@ def _instrument(self, **kwargs):
_get_tracer(
kwargs.get("engine"), kwargs.get("tracer_provider")
),
kwargs.get("service"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove service from docstring.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@lzchen lzchen merged commit e742cf7 into open-telemetry:master Nov 23, 2020
@srikanthccv srikanthccv deleted the sqlalchemy-semantic-conv branch December 5, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants