Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis instrumentation to follow semantic conventions #403

Merged
merged 5 commits into from
Apr 5, 2021

Conversation

srikanthccv
Copy link
Member

Description

Contributes to #159

@srikanthccv srikanthccv marked this pull request as ready for review April 4, 2021 14:47
@srikanthccv srikanthccv requested review from a team, owais and aabmass and removed request for a team April 4, 2021 14:47
span.set_attribute(_RAWCMD, query)
_set_connection_attributes(span, instance)
span.set_attribute("redis.args_length", len(args))
span.set_attribute("db.redis.args_length", len(args))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to db.redis.database_index; DB specific attribute keys should be in the form of db.{identifier}.{}.

@codeboten codeboten merged commit 634c2ac into open-telemetry:main Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants