Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominate @mauriciovasquezbernal for python-approvers #373

Closed
6 tasks done
c24t opened this issue Jan 22, 2020 · 4 comments
Closed
6 tasks done

Nominate @mauriciovasquezbernal for python-approvers #373

c24t opened this issue Jan 22, 2020 · 4 comments
Assignees
@mauriciovasquezbernal
Labels
meta Related to repo itself, process, community, ...

Comments

@c24t
Copy link
Member

c24t commented Jan 22, 2020 •
edited by mauriciovasquezbernal
Loading

GitHub Username

@mauriciovasquezbernal

Organization you are requesting membership in

@open-telemetry/python-approvers

Requirements

  • I have reviewed the community membership guidelines
  • I have enabled 2FA on my GitHub account
  • I have subscribed to the Gitter channel
  • I am actively contributing to 1 or more OpenTelemetry subprojects
  • I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
  • I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

Approvers are sponsored by @open-telemetry/python-maintainers.

List of contributions to the OpenTelemetry project

This ticket follows the community guidelines for adding approvers even though we don't need a code change to add members to teams. @mauriciovasquezbernal check the boxes and I'll close the ticket and add you!
@c24t c24t added the meta Related to repo itself, process, community, ... label Jan 22, 2020
@toumorokoshi
Copy link
Member

+1 Thanks Mauricio for all of your contributions!

@mauriciovasquezbernal
Copy link
Member

Done, thanks a lot!

@c24t c24t mentioned this issue Jan 27, 2020
Closed
6 tasks
@c24t
Copy link
Member Author

c24t commented Jan 27, 2020

@mauriciovasquezbernal you'll need to join the open-telemetry org too: open-telemetry/community#292.

@c24t
Copy link
Member Author

c24t commented Jan 28, 2020

Added!

@c24t c24t closed this as completed Jan 28, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@OlivierAlbertini @mayurkale22
feat(plugin-http): add/modify attributes (open-telemetry#643)
3d9b822 
* feat(plugin-http): add/modify attributes

closes open-telemetry#373, open-telemetry#394

Signed-off-by: Olivier Albertini <[email protected]>

* fix: change remotePort to localPort

refactor: remove useless checks
test: add assertions

Signed-off-by: Olivier Albertini <[email protected]>

* test(plugin-https): sync with http plugin

Signed-off-by: Olivier Albertini <[email protected]>

Co-authored-by: Mayur Kale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauriciovasquezbernal mauriciovasquezbernal

Labels
meta Related to repo itself, process, community, ...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toumorokoshi @mauriciovasquezbernal @c24t