Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OTEL_BSP_* environment variables #1120

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Add support for OTEL_BSP_* environment variables #1120

merged 5 commits into from
Sep 24, 2020
+53 −6

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 16, 2020

Fixes #1105

Description

Add support for OTEL_BSP_* environment variables

Fixes #1105

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit test case.

  • test_batch_span_processor_environment_variables

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl requested a review from a team September 16, 2020 07:53
@ocelotl ocelotl self-assigned this Sep 16, 2020
@ocelotl ocelotl force-pushed the issue_1105 branch 2 times, most recently from 5e1fcfc to 5a21daa Compare September 16, 2020 15:24
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Sep 17, 2020
codeboten
codeboten suggested changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, just a couple of comments. I'd like to see an update to the docs to list out available options.

opentelemetry-api/CHANGELOG.md Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py Show resolved Hide resolved
opentelemetry-sdk/CHANGELOG.md Outdated Show resolved Hide resolved
lzchen
lzchen reviewed Sep 23, 2020
View reviewed changes
opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py
)

if max_export_batch_size is None:
max_export_batch_size = Configuration().get(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have validation to ensure less than or equal to max queue size.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already implemented here.

codeboten
codeboten approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments.

@codeboten codeboten merged commit 4af1341 into open-telemetry:master Sep 24, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@mayurkale22
feat: add the UpDownCounter instrument (open-telemetry#1120)
469b759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@codeboten codeboten

@ocelotl ocelotl

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for OTEL_BSP_* environment variable for the batch span processor
3 participants
@ocelotl @codeboten @lzchen