-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added context propagation support to celery instrumentation #1135
Conversation
f909ff7
to
61b95f4
Compare
61b95f4
to
1f72b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this change looks pretty good to me. @owais is this addressing any of the open issues around celery integration? https://github.com/open-telemetry/opentelemetry-python/issues?q=is%3Aissue+is%3Aopen+celery
I think it should fix #876 and probably #862 as well. This PR does not fix #970 but it updates the docs to ackowledge the issue and recommends a solution (delayed instantiate tracing in celery workers so each worker gets it's own processor/exporter instance) See "setting up tracing" section and updated code examples in celery docs. @codeboten |
@owais Thanks for updating the description, this is great! Need one more approval. @open-telemetry/python-approvers approvers please take a look |
@@ -2,6 +2,9 @@ | |||
|
|||
## Unreleased | |||
|
|||
- Span operation names now include the task type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add PR link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Curious does this need to be implemented for other instrumentations or is this specific to celery (explicit context propagation)? |
This is very specific to celery. |
6f6ee05
to
0e6df16
Compare
Can you explain why? |
Sorry, I was answering this and confirming that it is specific to celery (celery context propagation) and does not apply to other instrumentations. |
celery context propagation still doesn't work on |
@MrMegaMango Please open a new issue |
Description
fixes #862
fixes #876
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: