Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a py.typed file every package. #1720

Merged

Conversation

owais
Copy link
Contributor

@owais owais commented Mar 28, 2021

Description

If I understand correctly, we only need a single py.typed file per package instead of every module.
Removed py.typed from a few modules and added it to the root of every
package.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested review from a team, aabmass and hectorhdzg and removed request for a team March 28, 2021 02:05
@owais owais added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Mar 28, 2021
Removed py.typed from a few modules and added it to the root of every
package. We only need one py.typed per package.
@owais owais force-pushed the add-py-typed-file-to-propagate-package branch from e5aaf18 to 63e34dc Compare March 28, 2021 02:08
@lzchen lzchen merged commit d06ba7b into open-telemetry:main Mar 30, 2021
@owais owais deleted the add-py-typed-file-to-propagate-package branch March 30, 2021 16:01
@aabmass aabmass mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants