Update gettracer #1854
Update gettracer #1854
Conversation
eddyleelin
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
CHANGELOG.md
Outdated
| @@ -36,6 +36,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#1809])(https://github.com/open-telemetry/opentelemetry-python/pull/1809) | |||
| - Fixed sequence values in OTLP exporter not translating | |||
| ([#1818](https://github.com/open-telemetry/opentelemetry-python/pull/1818)) | |||
| - Update get_tracer to return an empty string when passed an invalid name | |||
There was a problem hiding this comment.
This should be added to the "Unreleased" section of the changelog
There was a problem hiding this comment.
Just did it. Thanks!
| self.assertEqual( | ||
| tracer1.instrumentation_info, tracer2.instrumentation_info | ||
| ) | ||
|
|
There was a problem hiding this comment.
any reason for this test to be moved?
There was a problem hiding this comment.
I believed that having the more granular tests for the individual tracer would provide more information upon failing; then, this test just makes sure that the two tracers created are identical, which is asserted after each individual attribute is checked. I'm not sure if that's good practice, though, so I'd appreciate the feedback!
Co-authored-by: alrex <[email protected]>
|
Code looks good, please update the branch so we can merge it. |
|
@eddyleelin please fix the linting issues. |
|
Thanks so much to everyone for the patience, support, and helpful feedback! I really appreciate this community!! @codeboten @owais @lzchen |
Description
Specification change #1654 requires invalid names to be converted to an empty string, as described in the tracer specification below. Passing
Noneor the empty string""as thenameparameter totrace.get_tracer(name, version)will now return a tracer with an empty string fortracer.instrumentation_info.name. Full details available in the Trace API specifications.Fixes #1849
How Has This Been Tested?
get_tracerfor the given invalid inputs, and thetox -e test-core-sdktests passed.Does This PR Require a Contrib Repo Change?
Checklist:
Hooray for my first PR!