Add a more informative error message when parsing ENV headers #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ocelotl
force-pushed
the
issue_2376
branch
2 times, most recently
from
abe3430
to
52ca7c7
Compare
lzchen
reviewed
Nov 22, 2022
lzchen
reviewed
Nov 22, 2022
...porter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/trace_exporter/__init__.py
Show resolved
Hide resolved
srikanthccv
approved these changes
Nov 30, 2022
lzchen
approved these changes
Nov 30, 2022
Also, rename the function to make it clear that this parsing is specific to headers provided via ENV variables. Fixes open-telemetry#2376
ocelotl
added
the
Approve Public API check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2376
From #2375
Thanks, @cincodenada!