-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff instead of black/isort for autoformatting #3822
base: main
Are you sure you want to change the base?
Conversation
7a5d528
to
91e8019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual changed file-please review
scripts/eachdist.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual changed file-please review
BTW do you see what's wrong with the Public API check? |
I think it's just flaking, the output doesn't have any results even though its failing |
I think at least something like this is required:
UPDATE: ah seen your PR :) |
BTW changelog would be nice to have the ruff commit handy |
I didn't add an entry initially because I don't think it's applicable to the changelog audience (consumers of the library). Happy to add if you think otherwise |
It would be handy for people poking with the code :) |
Adding "do not merge label" until we decide for sure on Ruff replacing flake8 and pylint as well. |
Marking as draft to prevent accidental merging. |
Once the conflict has been resolved this should be ready to land right? |
Description
Part 1/2 for #3260
This only migrates the auto formatting capabilities. Linting will be in a separate PR which could use more scrutiny. Most of these changes look formatting changes and small things. See https://docs.astral.sh/ruff/formatter/black/ for known differences.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A this only reformats the code
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR: I will send a PR after discussions are done :)
Checklist: