Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logs example re root logger #4090

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Update logs example re root logger #4090

merged 3 commits into from
Jul 30, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jul 29, 2024 •
edited by xrmx
Loading

Description

Updates logs export setup example so that it no longer uses the root logger. Currently it does because it's a direct call to logging.info without prior getLogger("some name"), like in the simple example.

Fixes #3625

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Jul 29, 2024
Closed
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review July 29, 2024 22:22
@tammy-baylis-swi tammy-baylis-swi requested a review from a team July 29, 2024 22:22
@lzchen lzchen merged commit b9cadc0 into open-telemetry:main Jul 30, 2024
284 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the update-logs-example branch July 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecursionError in SimpleLogRecordProcessor after shutdown method being called
3 participants
@tammy-baylis-swi @xrmx @lzchen