Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LogData constructible by removing #[non_exhaustive], fixes #1217 #1222

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

FSMaxB
Copy link
Contributor

@FSMaxB FSMaxB commented Aug 23, 2023

Fixes #1217

Changes

Remove the #[non_exhaustive] attribute from LogData so it can be constructed, allowing direct use of LogExporter.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@FSMaxB FSMaxB requested a review from a team August 23, 2023 06:57
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: FSMaxB / name: Max Bruckner (699cb24)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ba8f9f) 49.1% compared to head (699cb24) 49.1%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1222   +/-   ##
=====================================
  Coverage   49.1%   49.1%           
=====================================
  Files        173     173           
  Lines      20937   20937           
=====================================
  Hits       10301   10301           
  Misses     10636   10636           
Files Changed Coverage Δ
opentelemetry-sdk/src/export/logs/mod.rs 0.0% <ø> (ø)
opentelemetry-sdk/src/runtime.rs 92.1% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TommyCpp TommyCpp merged commit a3e0ab6 into open-telemetry:main Aug 23, 2023
12 checks passed
@FSMaxB FSMaxB deleted the allow-constructing-log-data branch September 13, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to construct LogData
4 participants