Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to confirm bug in metrics sdk #1597

Merged

Conversation

cijothomas
Copy link
Member

Fixes #
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@cijothomas cijothomas requested a review from a team March 4, 2024 23:52
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 67.0%. Comparing base (eb1a09b) to head (acb4d17).
Report is 4 commits behind head on main.

Files Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 0.0% 101 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1597     +/-   ##
=======================================
- Coverage   67.3%   67.0%   -0.3%     
=======================================
  Files        138     138             
  Lines      19355   19515    +160     
=======================================
+ Hits       13029   13084     +55     
- Misses      6326    6431    +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for validating the issue.

@cijothomas cijothomas merged commit 7cff678 into open-telemetry:main Mar 5, 2024
14 of 15 checks passed
@cijothomas cijothomas deleted the cijothomas/test-for-known-bug branch March 5, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants