For Delta Temporarlity, avoid exporting when no new measurements are made #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdost
approved these changes
Sep 29, 2024
lalitb
approved these changes
Sep 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2153 +/- ##
=======================================
+ Coverage 79.0% 79.2% +0.2%
=======================================
Files 121 121
Lines 20933 20937 +4
=======================================
+ Hits 16549 16600 +51
+ Misses 4384 4337 -47 ☔ View full report in Codecov by Sentry. |
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Sep 30, 2024
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1598 by doing a simple fix.
This area still require more refactoring (#2145), but this does the job for now, and avoids sending "empty" metrics to exporters.