Skip to content

Commit

Permalink
Add cockroachdb to db.system semantic conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
rcrowe committed May 26, 2021
1 parent bad49c7 commit 13413bc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ release.
- Add JSON RPC specific conventions ([#1643](https://github.com/open-telemetry/opentelemetry-specification/pull/1643)).
- Add Memcached to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)).
- Add semantic convention attributes for the host device and added OS name and version ([#1596](https://github.com/open-telemetry/opentelemetry-specification/pull/1596)).
- Add CockroachDB to Database specific conventions ([#1725](https://github.com/open-telemetry/opentelemetry-specification/pull/1725)).

### Compatibility

Expand Down
3 changes: 3 additions & 0 deletions semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ groups:
- id: memcached
value: 'memcached'
brief: 'Memcached'
- id: cockroachdb
value: 'cockroachdb'
brief: 'CockroachDB'
- id: connection_string
tag: connection-level
type: string
Expand Down
1 change: 1 addition & 0 deletions specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
| `geode` | Apache Geode |
| `elasticsearch` | Elasticsearch |
| `memcached` | Memcached |
| `cockroachdb` | CockroachDB |
<!-- endsemconv -->

### Notes and well-known identifiers for `db.system`
Expand Down

0 comments on commit 13413bc

Please sign in to comment.