Skip to content

Commit

Permalink
[semantic_conventions/resource] fix google platform openshift naming
Browse files Browse the repository at this point in the history
Signed-off-by: Benedikt Bongartz <[email protected]>
  • Loading branch information
frzifus committed Jan 12, 2023
1 parent 36cc76a commit 148910b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ release.

- Add `code.lineno` source code attribute
([#3029](https://github.com/open-telemetry/opentelemetry-specification/pull/3029))
- Rename google openshift platform attribute from `google_cloud_openshift` to `gcp_openshift`
to match the existing `cloud.provider` prefix.
[#3095](https://github.com/open-telemetry/opentelemetry-specification/pull/3095)


### Compatibility

Expand Down
4 changes: 2 additions & 2 deletions semantic_conventions/resource/cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ groups:
- id: gcp_app_engine
value: 'gcp_app_engine'
brief: Google Cloud App Engine (GAE)
- id: google_cloud_openshift
value: 'google_cloud_openshift'
- id: gcp_openshift
value: 'gcp_openshift'
brief: Red Hat OpenShift on Google Cloud
- id: ibm_cloud_openshift
value: 'ibm_cloud_openshift'
Expand Down
2 changes: 1 addition & 1 deletion specification/resource/semantic_conventions/cloud.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
| `gcp_kubernetes_engine` | Google Cloud Kubernetes Engine (GKE) |
| `gcp_cloud_functions` | Google Cloud Functions (GCF) |
| `gcp_app_engine` | Google Cloud App Engine (GAE) |
| `google_cloud_openshift` | Red Hat OpenShift on Google Cloud |
| `gcp_openshift` | Red Hat OpenShift on Google Cloud |
| `ibm_cloud_openshift` | Red Hat OpenShift on IBM Cloud |
| `tencent_cloud_cvm` | Tencent Cloud Cloud Virtual Machine (CVM) |
| `tencent_cloud_eks` | Tencent Cloud Elastic Kubernetes Service (EKS) |
Expand Down

0 comments on commit 148910b

Please sign in to comment.