Skip to content

Commit

Permalink
Disable db.statement via instrumentation configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared committed Apr 28, 2021
1 parent fd59503 commit 656cee2
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ release.
- Add details for filling resource for AWS Lambda. ([#1610](https://github.com/open-telemetry/opentelemetry-specification/pull/1610))
- Add already specified `messaging.rabbitmq.routing_key` span attribute key to the respective YAML file.
- Clarify usage of "otel." attribute namespace. ([#1640](https://github.com/open-telemetry/opentelemetry-specification/pull/1640))
- Add possibility to disable `db.statement`. ([#1659](https://github.com/open-telemetry/opentelemetry-specification/pull/1659))
- Add possibility to disable `db.statement` via instrumentation configuration. ([#1659](https://github.com/open-telemetry/opentelemetry-specification/pull/1659))

### Compatibility

Expand Down
2 changes: 1 addition & 1 deletion semantic_conventions/trace/database.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ groups:
type: string
required:
conditional: >
Required if applicable or not explicitly disabled.
Required if applicable or not explicitly disabled via instrumentation configuration.
brief: >
The database statement being executed.
note: The value may be sanitized to exclude sensitive information.
Expand Down
2 changes: 1 addition & 1 deletion specification/trace/semantic_conventions/database.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Usually only one `db.name` will be used per connection though.

**[3]:** The value may be sanitized to exclude sensitive information.

**[4]:** Required if applicable or not explicitly disabled.
**[4]:** Required if applicable or not explicitly disabled via instrumentation configuration.

**[5]:** When setting this to an SQL keyword, it is not recommended to attempt any client-side parsing of `db.statement` just to get this property, but it should be set if the operation name is provided by the library being instrumented. If the SQL statement has an ambiguous operation, or performs more than one operation, this value may be omitted.
<!-- endsemconv -->
Expand Down

0 comments on commit 656cee2

Please sign in to comment.