query is sampling relevant

open-telemetry · Apr 11, 2023 · b995230 · b995230
1 parent 604baab
commit b995230
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/semantic_conventions/trace/http.yaml b/semantic_conventions/trace/http.yaml
@@ -136,13 +136,14 @@ groups:
       - ref: net.sock.host.addr
         requirement_level: opt_in
       - ref: net.sock.host.port
-      - ref: url.path
-        sampling_relevant: true
-        requirement_level: required
       - ref: url.scheme
         sampling_relevant: true
         requirement_level: required
         examples: ["http", "https"]
+      - ref: url.path
+        sampling_relevant: true
+        requirement_level: required
       - ref: url.query
+        sampling_relevant: true      
         requirement_level:
           conditionally_required: if available.
diff --git a/specification/trace/semantic_conventions/http.md b/specification/trace/semantic_conventions/http.md
@@ -290,6 +290,7 @@ Following attributes MUST be provided **at span creation time** (when provided a
 * [`net.host.name`](span-general.md)
 * [`net.host.port`](span-general.md)
 * `url.path`
+* `url.query`
 * `url.scheme`
 <!-- endsemconv -->