code review

open-telemetry · Feb 17, 2023 · d6d2186 · d6d2186
1 parent 07b935b
commit d6d2186
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/semantic_conventions/resource/cloud.yaml b/semantic_conventions/resource/cloud.yaml
@@ -21,6 +21,9 @@ groups:
             - id: 'gcp'
               value: 'gcp'
               brief: 'Google Cloud Platform'
+            - id: 'heroku'
+              value: 'heroku'
+              brief: 'Heroku Platform as a Service'
             - id: 'ibm_cloud'
               value: 'ibm_cloud'
               brief: 'IBM Cloud'

diff --git a/semantic_conventions/resource/cloud_provider/heroku.yaml b/semantic_conventions/resource/cloud_provider/heroku.yaml
@@ -17,7 +17,7 @@ groups:
           Commit hash for the current release
         examples: [ 'e6134959463efd8966b20e75b913cafe3f5ec' ]
         requirement_level: optional
-      - id: id
+      - id: app.id
         type: string
         brief: >
           Unique identifier for the application

diff --git a/specification/resource/semantic_conventions/cloud.md b/specification/resource/semantic_conventions/cloud.md
@@ -29,6 +29,7 @@
 | `aws` | Amazon Web Services |
 | `azure` | Microsoft Azure |
 | `gcp` | Google Cloud Platform |
+| `heroku` | Heroku Platform as a Service |
 | `ibm_cloud` | IBM Cloud |
 | `tencent_cloud` | Tencent Cloud |
 

diff --git a/specification/resource/semantic_conventions/cloud_provider/heroku.md b/specification/resource/semantic_conventions/cloud_provider/heroku.md
@@ -11,7 +11,7 @@
 |---|---|---|---|---|
 | `heroku.creation_timestamp` | string | Time and date the release was created | `2022-10-23T18:00:42Z` | Optional |
 | `heroku.commit` | string | Commit hash for the current release | `e6134959463efd8966b20e75b913cafe3f5ec` | Optional |
-| `heroku.id` | string | Unique identifier for the application | `2daa2797-e42b-4624-9322-ec3f968df4da` | Optional |
+| `heroku.app.id` | string | Unique identifier for the application | `2daa2797-e42b-4624-9322-ec3f968df4da` | Optional |
 <!-- endsemconv -->
 
 **Mapping:**
@@ -25,4 +25,6 @@
 | `HEROKU_RELEASE_VERSION`           | `service.version`           |
 | `HEROKU_SLUG_COMMIT`               | `heroku.commit`             |
 
+Additionally, [the `cloud.provider` resource attribute MUST be set to `heroku`](../cloud.md).
+
 [Heroku dyno metadata]: https://devcenter.heroku.com/articles/dyno-metadata