-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify if HTTP metrics semantic conventions require ALL the metrics to be implemented #2972
Comments
I don't think we have a definition for this anywhere, not even for tracing, right? |
That's exactly why I opened this issue - in order for us to move semantic convention to Stable, we need to have clarity. |
I'm pretty in the camp of having a certain set of metrics marked as required since that means there is a dependable interface. This does mean that the bar for marking more metrics as required would be a breaking change though. |
So thinking about this a good bit. We want a "T-shaped" API. The idea being you have a set of known consistent http metrics that must be included for baseline observability. Instrumentation can go deeper (and we can do this with optional/allowed metrics), but we should have a baseline that is consistent for tooling & expectation purposes. |
Would this be a simple boolean?
Or would this follow a similar structure to attributes requirement level? i.e.
|
@jamesmoessis I created #3176 to discuss the desired levels and their definition (also beyond just HTTP). |
What did you expect to see?
The HTTP metrics semantic convention spec should provide clarity "what is considered a compliant implementation", e.g. "an implementation is considered compliant if it has implemented all of the metrics described by this spec" or "an implementation is considered compliant if it has implemented at least one of the metrics described by this spec" or mark some metrics as REQUIRED and say "an implementation is considered compliant if and only if it has implemented ALL the REQUIRED metrics described by this spec".
Additional context.
The current spec has vague wording "The following metric instruments MUST be used to describe HTTP operations. They MUST be of the specified type and units."
The text was updated successfully, but these errors were encountered: