Add http metrics yaml #3158
Merged
Add http metrics yaml #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
spec:metrics
reyang
approved these changes
Jan 31, 2023
|
+1 on adding the notion of optional instruments to the YAML. Is there a ticket open for this? |
jsuereth
approved these changes
Feb 2, 2023
|
arminru
approved these changes
Feb 3, 2023
arminru
reviewed
Feb 3, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add http metrics yaml * Update change log * Fix notes * Fix link * Remove unnecessary field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2972 by adding text to say whether each instrument is required or optional (ideally should be added to yaml?)
Fixes #2822
Fixes #2974 by including same definition of
net.host.namefrom tracingFixes #2976 by making
http.server.request.sizeand friends optionalChanges
Adds http metrics yaml file based on @jamesmoessis build tool changes in open-telemetry/build-tools#79
For non-trivial changes, follow the change proposal process and link to the related issue(s) and/or OTEP(s), update the
CHANGELOG.md, and also be sure to updatespec-compliance-matrix.mdif necessary.Related issues #2666, #2001
NOTE: Markdown rendering will be improved in a future PR, after open-telemetry/build-tools#129