Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the current Logs Bridge API/SDK design doesn’t prevent future addition of end-user facing log API #3301

Closed
Tracked by #2911
tigrannajaryan opened this issue Mar 7, 2023 · 4 comments · Fixed by #3346
Assignees
Labels
spec:logs Related to the specification/logs directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Mar 7, 2023

This was raised by @bogdandrutu during presentation of the Logs Bridge API/SDK in spec SIG.

We may need to show what a hypothetical end-user facing log API may look like and that it is doable as an addition to the Bridge API.

@tigrannajaryan tigrannajaryan added the spec:logs Related to the specification/logs directory label Mar 7, 2023
@tigrannajaryan
Copy link
Member Author

cc @open-telemetry/specs-logs-approvers

@tigrannajaryan tigrannajaryan changed the title Make sure the current Logs Bridge API/SDK design doesn’t prevent future addition of end-user facinf log API Make sure the current Logs Bridge API/SDK design doesn’t prevent future addition of end-user facing log API Mar 7, 2023
@jack-berg
Copy link
Member

Its a good question. In java, we publish all our APIs in a single artifact called opentelemetry-api. Within this there are different packages (a java specific organization construct) for each signal (e.g. io.opentelemetry.api.trace, io.opentelemetry.api.metrics, etc).

Although we call it the "Logs Bridge API", I was thinking that the code would land in the standard opentelemetry-api artifact, under the io.opentelemetry.api.logs package. I figured we would call it the Log Bridge API in documentation (opentelemetry.io, javadoc, etc), but don't need to reflect that name in the package. I.e. DON'T call the package something like io.opentelemetry.api.logbridge.

This would allow us to rebrand and expand the scope to be user facing, in the event of a future end-user facing log API. The current shape of the Log Bridge API lends itself well to becoming user facing some day, but would need some (backwards compatible) additions like the ability to query for the enabled log level.

I want to reiterate that while I think our strategy would allow us to expand the scope to be user facing, there's a strong consensus in the java SIG that we do not want to create yet another logging API, and would push back on any future spec movement to do so.

@tigrannajaryan
Copy link
Member Author

@jack-berg that's my feeling as well. Keep package name generic. Later we can add methods to Logger (e.g. error() or debug()).

I don't know if we need to show more details of what a potential extended API can look like.

@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-logs-approvers any thoughts on this?

@arminru arminru added the triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal label Apr 3, 2023
tigrannajaryan pushed a commit that referenced this issue Apr 6, 2023
Resolves #3301.

---------

Co-authored-by: Armin Ruech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory triaged-accepted The issue is triaged and accepted by the OTel community, one can proceed with creating a PR proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants